Skip to content

adds 500-511 status codes #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2023
Merged

adds 500-511 status codes #1357

merged 2 commits into from
Sep 30, 2023

Conversation

muttonchop
Copy link
Contributor

Changes

Adds the 500 - 511 status codes, as mentioned by #1354

How to Review

I didn't see where error status codes are tested. Should the examples be extended to validate the additional status values?

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: aede007

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
openapi-typescript-helpers Patch
openapi-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@muttonchop
Copy link
Contributor Author

@drwpow I'm not sure how the change set should work for this. Let me know if I need to change it.

@muttonchop muttonchop marked this pull request as ready for review September 25, 2023 22:35
@drwpow
Copy link
Contributor

drwpow commented Sep 25, 2023

@muttonchop if you could change it to patch that’d be better (in pre-1.0 releases, the unofficial standard is minor means “breaking change” or “significant feature” and patch is for everything else; in 1.0 and beyond it follows normal semver).

@drwpow drwpow merged commit 996e51e into openapi-ts:main Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants